ozone icon indicating copy to clipboard operation
ozone copied to clipboard
verified publisher icon apache

HDDS-11442. Add dashboard for memory consumption metrics

Open len548 opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

Added Ozone - Memory Consumption Metrics.json to measure memory consumption for the services: OM, SCM, DN and Recon. The following metrics are tracked:

  • Heap usage
  • Non-heap usage
  • GC stats
  • Thread stats
  • JVM load

Also, the dashboard includes these metrics for Ozone:

  • The number of keys
  • The key creation rate

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11442

How was this patch tested?

Deployed locally. Screenshot 2024-09-13 at 13 13 09 image image image image

len548 avatar Sep 13 '24 14:09 len548

@tanvipenumudy @kerneltime Hi, I merged some changes based on the comments and would like you to review it. Thank you for your time!

len548 avatar Sep 23 '24 06:09 len548

/pending review comments

adoroszlai avatar Nov 12 '24 07:11 adoroszlai

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

github-actions[bot] avatar Dec 05 '24 00:12 github-actions[bot]

Re-opened this one after discussing with @len548 about continuing this effort.

fapifta avatar Dec 09 '24 12:12 fapifta

Thank you for reviews, @kerneltime and @tanvipenumudy although it was a long time ago. I addressed all the comments so can you review again please?

len548 avatar Dec 18 '24 09:12 len548

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

github-actions[bot] avatar Jan 09 '25 00:01 github-actions[bot]

@kerneltime @tanvipenumudy can you give some time to this PR and review once more after the changes? Thank you!

fapifta avatar Jan 29 '25 06:01 fapifta

/ready

dombizita avatar Feb 03 '25 12:02 dombizita

I am merging this one, it looks good in general, if we find any further tweaks, we can do a follow up to fix it.

fapifta avatar Feb 06 '25 00:02 fapifta