ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-10926. Block deletion should update container merkle tree.

Open errose28 opened this issue 1 year ago • 1 comments

Builds off #6778

What changes were proposed in this pull request?

When a block is deleted from a container, it should be marked as deleted in the container merkle tree. This tells peer datanodes that the data be skipped if they have not yet processed the deletion but find there is an error with this block. The chunk, block, and container hashes in the tree should not change.

What is the link to the Apache JIRA

HDDS-10926

How was this patch tested?

Unit test added

errose28 avatar Jun 27 '24 17:06 errose28

Will give another look post addressing of review comments and rebase.

kerneltime avatar Jun 28 '24 20:06 kerneltime

For tests to pass I had to add the same metrics unregister workaround from #6945. ~HDDS-10239~ HDDS-11254 will properly close the checksum tree manager when everything is connected and this will no longer be necessary.

errose28 avatar Jul 31 '24 17:07 errose28

Run on my fork is green, waiting for verification here as well.

errose28 avatar Jul 31 '24 19:07 errose28

Thanks @errose28 . Nice commit messages btw :D

smengcl avatar Aug 06 '24 22:08 smengcl