ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-10655. Support PutObjectTagging, GetObjectTagging, and DeleteObjectTagging

Open ivandika3 opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

After HDDS-10435 has implemented the fundamental changes to support object tags. This patch supports the S3 object tagging APIs.

This patch will create add new S3 tagging endpoints as well as add OM request to object tagging requests. Additionally, this patch also added related tagging metrics (S3 and OM metrics).

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10655

How was this patch tested?

Unit, integration, and acceptance tests.

ivandika3 avatar May 31 '24 07:05 ivandika3

@SaketaChalamchala @tanvipenumudy @Tejaskriya Could you help take a look as well?

ivandika3 avatar Jun 02 '24 08:06 ivandika3

Thanks @ivandika3 for the patch, let's me see.

guohao-rosicky avatar Jun 03 '24 12:06 guohao-rosicky

@guohao-rosicky Gentle ping, could you review this when you have time?

ivandika3 avatar Jul 01 '24 01:07 ivandika3

@adoroszlai Thanks a lot for reviewing such a large patch.

In the future I think it would be better to split such huge changes (255KB patch) into sub-tasks. E.g. introduce OM-side feature first, then add usage in S3G; maybe you can come up with more granular items.

Thanks, I'll keep this in mind. In the future I will create a feature branch so that we don't have a situation like https://issues.apache.org/jira/browse/HDDS-11251 that causes dead code.

ivandika3 avatar Nov 11 '24 10:11 ivandika3

Thanks @ivandika3 for the patch, @SaketaChalamchala, @Tejaskriya for the review.

adoroszlai avatar Nov 17 '24 08:11 adoroszlai