ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-10917. Refactoring more tests from TestContainerBalancerTask

Open Montura opened this issue 1 year ago • 2 comments

In PR for HDDS-9889 we discussed with Siddhant Sangwan that tests form org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTask could be refactored using MockedSCM class (introduced in HDDS-9889)

Some work has been already done in:

  1. https://github.com/apache/ozone/pull/5758
  2. https://github.com/apache/ozone/pull/6537

What changes were proposed in this pull request?

  1. Refactor some tests from org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTask

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10917

How was this patch tested?

Use standalone tests

Montura avatar May 28 '24 08:05 Montura

@siddhantsangwan, take a look please

Montura avatar May 31 '24 08:05 Montura

@siddhantsangwan , take a look please

Montura avatar Jun 27 '24 18:06 Montura

@afilpp @sarvekshayr @sumitagrawl @Tejaskriya can you please help review this?

adoroszlai avatar Jul 15 '24 19:07 adoroszlai

Thanks for the patch @Montura. Are you also planning to move the other tests in TestContainerBalancerTask to TestContainerBalancerDatanodeNodeLimit with new PRs?

Sure, I have plans to finish it in one or two PRs (@siddhantsangwan has told first time that too many lines per one PR).

I'd like to finish in one PR of course.

Montura avatar Jul 25 '24 22:07 Montura

Sure, I have plans to finish it in one or two PRs (@siddhantsangwan has told first time that too many lines per one PR). I'd like to finish in one PR of course.

Splitting it into many PRs will make it easy for reviews, it makes sense. Thanks for addressing the comments, LGTM

Tejaskriya avatar Jul 26 '24 07:07 Tejaskriya

@adoroszlai , could you merge please? Or I have to do something else?

Montura avatar Jul 31 '24 20:07 Montura

Thanks @Montura for the patch, @sarvekshayr, @Tejaskriya for the review.

adoroszlai avatar Aug 01 '24 05:08 adoroszlai