HDDS-10917. Refactoring more tests from TestContainerBalancerTask
In PR for HDDS-9889 we discussed with Siddhant Sangwan that tests form org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTask could be refactored using MockedSCM class (introduced in HDDS-9889)
Some work has been already done in:
- https://github.com/apache/ozone/pull/5758
- https://github.com/apache/ozone/pull/6537
What changes were proposed in this pull request?
- Refactor some tests from
org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTask
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10917
How was this patch tested?
Use standalone tests
@siddhantsangwan, take a look please
@siddhantsangwan , take a look please
@afilpp @sarvekshayr @sumitagrawl @Tejaskriya can you please help review this?
Thanks for the patch @Montura. Are you also planning to move the other tests in TestContainerBalancerTask to TestContainerBalancerDatanodeNodeLimit with new PRs?
Sure, I have plans to finish it in one or two PRs (@siddhantsangwan has told first time that too many lines per one PR).
I'd like to finish in one PR of course.
Sure, I have plans to finish it in one or two PRs (@siddhantsangwan has told first time that too many lines per one PR). I'd like to finish in one PR of course.
Splitting it into many PRs will make it easy for reviews, it makes sense. Thanks for addressing the comments, LGTM
@adoroszlai , could you merge please? Or I have to do something else?
Thanks @Montura for the patch, @sarvekshayr, @Tejaskriya for the review.