ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-10699. Refactor ContainerBalancerTask and tests in TestContainerBalancerTask

Open Montura opened this issue 10 months ago • 1 comments

In PR for HDDS-9889 we discussed with Siddhant Sangwan that tests form org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTask could be refactored using MockedSCM class (introduced in HDDS-9889)

What changes were proposed in this pull request?

  1. Refactor some tests from org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTask
  2. Made some cleanups in org.apache.hadoop.hdds.scm.container.balancer.ContainerBalancerTask related to changes in refactored test

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10699

How was this patch tested?

Use standalone tests

Montura avatar Apr 16 '24 10:04 Montura

@siddhantsangwan, please look first at https://github.com/apache/ozone/pull/5758. We have to finish it first.

Montura avatar Apr 22 '24 09:04 Montura

@adoroszlai, merge the changes please

Montura avatar May 17 '24 07:05 Montura

Thanks @Montura for the patch, @sumitagrawl, @Tejaskriya for the review.

adoroszlai avatar May 17 '24 08:05 adoroszlai