ozone
ozone copied to clipboard
HDDS-9384. Update OpenTelemetry traces in the write path
What changes were proposed in this pull request?
HDDS-9384. [hsync] Update OpenTelemetry traces in the write path
Please describe your PR in detail:
Traces for
- Ratis callback function (ContainerStateMachine)
- DataNode PutBlock/WriteChunk
- Client BlockOutputStream WriteChunk
What is the link to the Apache JIRA
How was this patch tested?
Manual test. Screenshots
Maybe the updated PR template is a bit confusing, but "Title" is supposed to be entered only in the title field, not duplicated in the description field.
CC @hemantk-12
Maybe the updated PR template is a bit confusing, but "Title" is supposed to be entered only in the title field, not duplicated in the description field.
CC @hemantk-12
Yeah, I agree. I've also seen couple of PRs with similar duplicated title.
Is there a way to update PR template to fill "Title" field with this instead of commit message? Otherwise we can update the template to something:
## Provide a general summary of your changes in the Title above
Title should provide one sentence overview of the purpose of the PR.
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix
1. **Description:**
* What changes are proposed in the PR? and Why? It would be better if it is written from third person's perspective not just for the reviewer.
* Provide as much context and rationale for the pull request as possible. It could be copy-paste from the Jira's description if the jira is well defined.
* If it is complex code, describe the approach used to solve the issue. If possible attach design doc, issue investigation, github discussion, etc.
2. **PR examples:** [PR#3980](https://github.com/apache/ozone/pull/3980), [PR#5265](https://github.com/apache/ozone/pull/5265), [PR#4701](https://github.com/apache/ozone/pull/4701), [PR#5283](https://github.com/apache/ozone/pull/5283), [PR#5300](https://github.com/apache/ozone/pull/5300))
Example 3 in https://axolo.co/blog/p/part-3-github-pull-request-template
Attach a few screenshots after the change. It's now able to connect thousands of trace spans.
@chungen0126