ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-7338. Reduced number of OzoneVolume constructors

Open myskov opened this issue 2 years ago • 1 comments

What changes were proposed in this pull request?

I reduced number of constructors in org.apache.hadoop.ozone.client.OzoneVolume to 1 (from 7) and refactored javadoc comments.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7338

How was this patch tested?

unit tests

myskov avatar Oct 15 '22 17:10 myskov

@aswinshakil

kerneltime avatar Oct 17 '22 16:10 kerneltime

@adoroszlai I don't think so. Let's imagine a case that a Hadoop user uses an old client (without these changes) to access data on a newer (with these changes) remote Ozone cluster. As these changes consist only of internal ozone client changes, there should not be any issues with backward compatibility.

myskov avatar Oct 22 '22 06:10 myskov

On backwards compatibility, need to ensure that changes to OzoneVolume constructors work with older versions of the om DB for the OmVolumeArgs that are returned by the metadatamanager and used in the patch to create the OzoneVolumes in the RpcClient.
For example the RpcClient bulidOzoneVolume issues an RPC request to the ozone manager to return the volumeinfo that is retrieved from the metadatamanager as a OmVolumeArgs from different versions .

neils-dev avatar Oct 23 '22 23:10 neils-dev

hey @myskov ~ there is one latest comment from @neils-dev . Please help take a look when you have time, thanks!

DaveTeng0 avatar Jan 30 '23 05:01 DaveTeng0

Thanks again @myskov for the patch. It turns out an improvement ticket had long been open for these constructors, finally implemented in #4262.

adoroszlai avatar Feb 16 '23 11:02 adoroszlai