ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-7305. Fix Hadoop imports

Open adoroszlai opened this issue 2 years ago • 2 comments

What changes were proposed in this pull request?

  • Replace one import from Hadoop's shaded Guava.
  • Add direct dependencies for various Apache Commons libs instead of relying on getting them transitively via Hadoop.

Different Hadoop versions may not depend on all these libraries (or shade different Guava version), so using transitive dependency explicitly (via import) risks breaking with some version of Hadoop.

https://issues.apache.org/jira/browse/HDDS-7305

How was this patch tested?

Regular CI: https://github.com/adoroszlai/hadoop-ozone/actions/runs/3228775529

adoroszlai avatar Oct 11 '22 19:10 adoroszlai

How did you identify the pom file changes? I understand the import change, but not sure how the pom file updates were speced out.

kerneltime avatar Oct 12 '22 06:10 kerneltime

How did you identify the pom file changes?

Trial and error. Added the exclude, then resolved build failures.

adoroszlai avatar Oct 12 '22 08:10 adoroszlai

Thanks @captainzmc for reviewing and merging this.

adoroszlai avatar Oct 19 '22 11:10 adoroszlai

Thanks @adoroszlai, I will cherry-pick this to release branch.

captainzmc avatar Oct 19 '22 11:10 captainzmc