ozone icon indicating copy to clipboard operation
ozone copied to clipboard

Published 20 hours ago • verified publisher icon apache

HDDS-6971. EC: Add EC block checksum computer.

Open aswinshakil opened this issue 2 years ago • 1 comments

What changes were proposed in this pull request?

EC keys do not have a way to provide checksum for getFileChecksum API. This JIRA provides an implementation for EC Checksum which can also be used for Data Integrity check later.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6971

TODO

  • [x] Add MD5 Checksum
  • [x] EC Coordinator fixes for generating checksum
  • [ ] Additional Unit and Integration Test

How was this patch tested?

This patch was tested manually and using integration tests.

aswinshakil avatar Sep 30 '22 17:09 aswinshakil

@duongkame

kerneltime avatar Oct 10 '22 16:10 kerneltime

Mostly changes looks ok to me. @jojochuang could you please take a final look? Thanks

umamaheswararao avatar Nov 14 '22 18:11 umamaheswararao

Thanks @aswinshakil for working on this. LGTM. Pending CI and pending @jojochuang final confirmation on his comments.

Could you also file doc JIRA for updating the docs with EC constraints? Ex: what is comparable between EC and Ratis and HDFS etc.

umamaheswararao avatar Nov 15 '22 18:11 umamaheswararao

Created DOC JIRA HDDS-7491 for EC FileChecksum

aswinshakil avatar Nov 15 '22 19:11 aswinshakil