ozone icon indicating copy to clipboard operation
ozone copied to clipboard

Published 20 hours ago • verified publisher icon apache

HDDS-7188. Read chunk files using netty ChunkedNioFile.

Open szetszwo opened this issue 2 years ago • 8 comments

See https://issues.apache.org/jira/browse/HDDS-7188

szetszwo avatar Aug 30 '22 08:08 szetszwo

cc @duongkame

kerneltime avatar Sep 19 '22 16:09 kerneltime

@duongkame @jojochuang @kerneltime please review

adoroszlai avatar Jan 20 '23 14:01 adoroszlai

I need to do another round of going over the usage and memory model.

kerneltime avatar Jan 21 '23 09:01 kerneltime

i saw this changes it's kind of an experiment with the ChunkBufferToByteString. Maybe we could run some tests and compare some metrics with using the original implementation of ChunkBuffer~?

DaveTeng0 avatar Jan 30 '23 07:01 DaveTeng0

@szetszwo can you please address the review comments?

kerneltime avatar Feb 06 '23 06:02 kerneltime

@kerneltime , just have replied to your comments.

szetszwo avatar Feb 08 '23 12:02 szetszwo

@DaveTeng0 , yes, we should benchmarks. Do you know if we have any existing tests to run?

szetszwo avatar Feb 08 '23 12:02 szetszwo

@szetszwo do you plan to continue with this PR? can you please rebase?

kerneltime avatar Jun 13 '24 16:06 kerneltime