ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-7076. Log container file path when container cannot be written.

Open Galsza opened this issue 2 years ago • 2 comments

What changes were proposed in this pull request?

Add container file path to error message when writing to container encounters an error

What is the link to the Apache JIRA

HDDS-7076

How was this patch tested?

Reproduce the error on a local cluster via taking away the write permission on container data by making its folder read only.

Galsza avatar Aug 15 '22 15:08 Galsza

Thanks for the patch @Galsza. LGTM, just one nitpicking comment inline.

duongkame avatar Aug 15 '22 16:08 duongkame

@Galsza Please try to avoid force-push when updating the PR. Here are some great articles that explain why:

https://developers.mattermost.com/blog/submitting-great-prs/#4-avoid-force-pushing https://www.freecodecamp.org/news/optimize-pull-requests-for-reviewer-happiness#request-a-review

adoroszlai avatar Aug 17 '22 15:08 adoroszlai

Thanks @Galsza for updating the patch. Thanks @duongnguyen0 for the review.

adoroszlai avatar Aug 18 '22 11:08 adoroszlai