ozone
ozone copied to clipboard
apache
HDDS-7090. EC: delete empty closed EC container
What changes were proposed in this pull request?
we need to check more states for EC container and delete empty closed EC container.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7090
How was this patch tested?
Unit test
We are refactoring how the container checks are handled in the new RM in #3743, so once that goes in this one will need changed to work in the way described there.
see @siddhantsangwan has already completed this work, so this patch just add the handler to RM. @adoroszlai @sodonnel @umamaheswararao please take a look!
i will create another jira to implement DeletingContainerHandler
We have left this new handler out of the RM chain deliberately for now, as its not really complete without the deleting handler. The plan is to implement the deleting handler and then add both it and this handler to the chain in the next PR.
Feel free to go ahead with implementing this change and the deleting handler in the next PR.
We have left this new handler out of the RM chain deliberately for now, as its not really complete without the deleting handler. The plan is to implement the deleting handler and then add both it and this handler to the chain in the next PR.
Feel free to go ahead with implementing this change and the deleting handler in the next PR.
i have implemented deleting container handler, #3881 , please take a look! @sodonnel
since #3881 is merged , we can merge this patch now, please take a look! @sodonnel @siddhantsangwan
@sodonnel @siddhantsangwan since this patch is simple, if no more comments from you, i will merge it tomorrow!
Hi @JacksonYao287, do we need to cherry-pick this PR and HDDS-7384 to ozone-1.3 branch?
Hi @JacksonYao287, do we need to cherry-pick this PR and HDDS-7384 to ozone-1.3 branch?
yea , please cherry-pick both HDDS-7090 and HDDS-7384, thanks! @kaijchen