ozone
ozone copied to clipboard
apache
HDDS-7082. Delete out of date audit logs
What changes were proposed in this pull request?
This ticket is to add delete action to log4j to delete our of date audit logs.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7082
How was this patch tested?
Test in cluster.
will this be just 30 days independent of size?
Yes, it will only remove the out of date logs regardless of the size.
@symious do you want to add a documentation page for audit config? It would be good to inform you that by default, we have the config set up for 30 days. The only other concern I heard is about what the default value should be. If there are no other opinions, we can merge this in. cc @errose28
@kerneltime Thanks for the suggestion. Are you suggesting adding a new md file in module of "hadoop-hdds-docs", which content package should I put the new audit log document? "Feature"?
I think it would be good to document audit as a feature somewhere in the official docs https://ci-hadoop.apache.org/view/Hadoop%20Ozone/job/ozone-doc-master/lastSuccessfulBuild/artifact/hadoop-hdds/docs/public/tools/auditparser.html is the mention of the audit. This can be a separate jira but would be good to explain the config and audit feature for Ozone.
Checked the module of "hadoop-hdds-docs", seems the package of "tools" is for command line tools? Maybe we can add a new page named "AuditLog in Ozone" like "Quota in Ozone" under "Feature" package?
Ozone audit logs and system logs use log4j for the configuration, so I think log4j config docs are the better reference for that rather than duplicating the info in our docs. If the default is changed to 30 days we could also just add a release note to 1.3.0, which might be more obvious than a new docs page. Something like the bullet entries here
Do we need to set these configs as default, or is it enough to document how to configure it?
