ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-6444. Merge HDDS-5875 into OMKeyCommitRequestWithFSO.

Open JyotinderSingh opened this issue 2 years ago • 1 comments

What changes were proposed in this pull request?

Merge changes from HDDS-5875 into the FSO code path.

Currently the cache on the OM that is used to host entries that have not yet been stored in the DB also stores tokens. The mechanism to update the cache needs to be updated to only store Key Information that should be persisted.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6444

How was this patch tested?

Added Integration Test

JyotinderSingh avatar Mar 28 '22 13:03 JyotinderSingh

@adoroszlai could you please review this change? I have added a test to verify the expected behavior after this change (token should not be persisted to cache table when adding keyinfo) and it is successfully passing. However, I am unable to reproduce the actual issue - since the test is passing even without the change (in the case of both OBS and FSO buckets). What I mean from this is that the token info is not getting persisted to the tables successfully.

During debugging (without this change) I observed that while we do write the token to the table, when we retrieve the key value back from the table this token is missing. I am not sure what might be causing this inconsistency.

JyotinderSingh avatar Mar 29 '22 05:03 JyotinderSingh