orc icon indicating copy to clipboard operation
orc copied to clipboard

ORC-1884: [C++] Add a maybe() API to the SearchArgumentBuilder

Open luffy-zh opened this issue 7 months ago • 3 comments

What changes were proposed in this pull request?

Add a maybe() API to the SearchArgumentBuilder to allow the insertion of an expression tree that is currently unsupported.

Why are the changes needed?

To enhance the SearchArgumentBuilder API with a new method called maybe(), we can create a SearchArgument tree for scenarios that may not be adequately addressed by existing methods.

How was this patch tested?

Uts in TestSearchArgument.cc can cover this patch.

Was this patch authored or co-authored using generative AI tooling?

NO

luffy-zh avatar May 03 '25 10:05 luffy-zh

Is maybe() a shortcut of literal(TruthValue::YES_NO_NULL)?

ffacs avatar May 06 '25 06:05 ffacs

Is maybe() a shortcut of literal(TruthValue::YES_NO_NULL)? Yes, maybe() can be considered a shortcut for literal(TruthValue::YES_NO_NULL). It provides a more concise way to express uncertainty or ambiguity in truth values.

luffy-zh avatar Jun 11 '25 02:06 luffy-zh

Hi, Yuanping (@ffacs), if you think it's okay, you can merge this. Feel free to merge this PR because I removed my review here. 😄

dongjoon-hyun avatar Jun 17 '25 23:06 dongjoon-hyun

Let me merge this.

dongjoon-hyun avatar Jun 30 '25 15:06 dongjoon-hyun

Thank you, @luffy-zh and all.

dongjoon-hyun avatar Jun 30 '25 15:06 dongjoon-hyun