orc icon indicating copy to clipboard operation
orc copied to clipboard

ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS

Open luffy-zh opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Detect Protobuf installed by Homebrew on macOS.

Why are the changes needed?

Deal with the issue discussed here

How was this patch tested?

Test it locally.

Was this patch authored or co-authored using generative AI tooling?

NO

luffy-zh avatar Jun 27 '24 09:06 luffy-zh

@kou Could you help review this? Thanks!

wgtmac avatar Jun 28 '24 15:06 wgtmac

The new github action doesn't run. I found the error message below:

Invalid workflow file: .github/workflows/build_and_test.yml#L224
The workflow is not valid. .github/workflows/build_and_test.yml (Line: 224, Col: 7): 'run' is already defined .github/workflows/build_and_test.yml (Line: 225, Col: 7): 'run' is already defined

https://github.com/apache/orc/actions/runs/9746489872

wgtmac avatar Jul 02 '24 02:07 wgtmac

Thank you, @luffy-zh , @wgtmac , @kou . Merged to main/2.0.

dongjoon-hyun avatar Jul 11 '24 15:07 dongjoon-hyun