orc icon indicating copy to clipboard operation
orc copied to clipboard

MINOR: Fix Patched Base doc in specification

Open Jefffrey opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

Fix patched base specification to state that only 5% of values are patched, not 10%

Why are the changes needed?

According to implementation:

https://github.com/apache/orc/blob/0828c2ff114f30c84e4a23fd42ed58c6615c6f97/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java#L535-L550

  • Also 10% of 512 doesn't fit in max patch list length of 31

Also fix some formatting issues.

Before:

image

After:

image

How was this patch tested?

N/A

Was this patch authored or co-authored using generative AI tooling?

No

Jefffrey avatar Jun 01 '24 09:06 Jefffrey

@dongjoon-hyun We have duplicate content at https://github.com/apache/orc-format/tree/main/specification. Is it inevitable to maintain the two copies unless we have a orc-site repo?

wgtmac avatar Jun 03 '24 02:06 wgtmac

@dongjoon-hyun We have duplicate content at https://github.com/apache/orc-format/tree/main/specification. Is it inevitable to maintain the two copies unless we have a orc-site repo?

Yes, it looks inevitable if we want to have this documentation in our website. Please let me know if you have an idea to mitigate this, @wgtmac .

dongjoon-hyun avatar Jul 09 '24 19:07 dongjoon-hyun

Merged to main.

dongjoon-hyun avatar Jul 09 '24 19:07 dongjoon-hyun