orc icon indicating copy to clipboard operation
orc copied to clipboard

ORC-1709: Upgrade GitHub Action `setup-java` to v4 and use built-in cache feature

Open sullis opened this issue 9 months ago • 4 comments

What changes were proposed in this pull request?

upgrade GitHub Action setup-java from v3 to v4

Also: setup-java supports a "cache" attribute. This allows us to remove the "cache" action from the workflow.

The "cache" attribute is documented in the setup-java README: https://github.com/actions/setup-java/blob/main/README.md

image

Why are the changes needed?

v4 is the latest version of setup-java

How was this patch tested?

GitHub Actions workflow.

Was this patch authored or co-authored using generative AI tooling?

No.

sullis avatar May 07 '24 19:05 sullis

cc @williamhyun

dongjoon-hyun avatar May 07 '24 19:05 dongjoon-hyun

Gentle ping for the above comment, @sullis .

If we are not sure, let's revert cache: 'maven' part and recover the old one. I believe the version bump is enough.

dongjoon-hyun avatar May 09 '24 03:05 dongjoon-hyun

Gentle ping, @sullis .

dongjoon-hyun avatar May 10 '24 03:05 dongjoon-hyun

Failed to save: Unable to reserve cache with key setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf48815b63ee075e7d3fc5a9c1f392f, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/1925/merge, Key: setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf48815b63ee075e7d3fc5a9c1f392f, Version: 3d88543681947283edf8997cb89a71c1522b2e39bc75c36ae780bd628eb8559d
Cache saved with the key: setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf[4](https://github.com/apache/orc/actions/runs/8990923635/job/24698981632#step:9:4)8815b63ee075e7d3fc5a9c1f392f

@sullis Is this working correctly?

Interesting. I'd like to know if "Failed to save: Unable to reserve cache with key " is repeatable.

Can you re-run the workflows?

sullis avatar May 10 '24 17:05 sullis

Do you have a JIRA ID? I can assign ORC-1709 to you.

dongjoon-hyun avatar Aug 07 '24 17:08 dongjoon-hyun