apache
ORC-1694: Upgrade gson to 2.9.0 for Benchmarks Hive
What changes were proposed in this pull request?
This PR aims to upgrade gson to 2.9.0 for Benchmarks Hive.
Why are the changes needed?
ORC-1676 upgraded to Hive4, Hive4 uses gson 2.9.0.
HIVE-26322: Upgrade gson to 2.9.0
https://issues.apache.org/jira/browse/HIVE-26322
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No
I checked Apache Spark master branch too. Apache Spark 4.0.0 will use old gson too still
Thanks to dongjoon for mentioning this.
Is this compatible?
I noticed that Hive was upgraded from gson 2.2.4 to 2.9.0, only the version was modified, UT did not fail, I will test it in ORC benchmark.
HIVE-26078: Upgrade gson to 2.8.9
HIVE-26322: Upgrade gson to 2.9.0
Thanks. If we can run all benchmarks without any issues, yes, we can upgrade this. :)
If we can run all benchmarks without any issues
I tested all the commands against the benchmark's README and found a few problems, though not related to the gson version.
Except ORC-1696 ORC-1699 has been merged, I can retest after ORC-1697 ORC-1700 is merged.
Since this is blocked by the others, I'll put it to Draft status to avoid any accidental merging.
Is this ready back
Yes
I guess you already tested in bench module for your testing.
Yes, because the PR mentioned before have been merged, I used the benchmark's README to execute it from beginning to end and found no exceptions.