ORC-1662: [C++] Upgrade protobuf to 3.21.12

Open ffacs opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

Upgrade protobuf to 3.21.12

Why are the changes needed?

To fix compilation failure on vs2022

How was this patch tested?

UT passed

Was this patch authored or co-authored using generative AI tooling?

Mar 21 '24 16:03 ffacs

Thanks for the PR! Unfortunately the new protobuf version is not compatible to compile libhdfspp. Let me investigate this.

Mar 22 '24 01:03 wgtmac

Update: I tried to upgrade libhdfspp. But unfortunately, I ran this command https://github.com/apache/orc/blob/main/c%2B%2B/libs/libhdfspp/pull_hdfs.sh#L25 without check. It wiped out my current directory (which is the root user profile).

Mar 22 '24 03:03 wgtmac

Oh, too bad for the accident.

Mar 22 '24 06:03 dongjoon-hyun