orc icon indicating copy to clipboard operation
orc copied to clipboard

Add a copyright messaging to the BpackingAvx512.hh

Open guangzegu opened this issue 2 years ago • 4 comments

What changes were proposed in this pull request?

Add copyright messaging to BpackingAvx512.hh

Why are the changes needed?

The vector unpacking functions in this PR https://github.com/apache/orc/pull/1375 is derived from Intel's QPL library, hence, Maybe copyright messaging should be added.

QPL Link: https://github.com/intel/qpl

How was this patch tested?

N/A

guangzegu avatar Dec 12 '23 16:12 guangzegu

If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that BpackingAvx512.hh is mix of ORC RLE decoder interface and AVX512 implementation.

wgtmac avatar Dec 13 '23 01:12 wgtmac

If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that BpackingAvx512.hh is mix of ORC RLE decoder interface and AVX512 implementation.↳

It would be even better if you could provide the original source of the code. I haven't checked if the referenced code has been modified on top of it, but if so, we can also add the corresponding AL2 header. FYI https://issues.apache.org/jira/browse/LEGAL-626

CalvinKirs avatar Jul 22 '24 09:07 CalvinKirs

If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that BpackingAvx512.hh is mix of ORC RLE decoder interface and AVX512 implementation.↳

It would be even better if you could provide the original source of the code. I haven't checked if the referenced code has been modified on top of it, but if so, we can also add the corresponding AL2 header. FYI https://issues.apache.org/jira/browse/LEGAL-626

The source code link: https://github.com/intel/qpl/blob/c2ced94c53c1ee22191201a59878e9280bc9b9b8/sources/core-sw/src/filtering/opt/qplc_unpack_be_8u_k0.h#L158 This implementation of this part is referred to Intel/qpl code. @wgtmac @dongjoon-hyun So sorry for late response. Something happened in my family in the past half a year.

wpleonardo avatar Jul 22 '24 13:07 wpleonardo

@wpleonardo Sorry to hear that

wgtmac avatar Jul 23 '24 03:07 wgtmac