orc icon indicating copy to clipboard operation
orc copied to clipboard

Published 20 hours ago • verified publisher icon apache

ORC-1285: [Java] Refactor selected vector support

Open deshanxiao opened this issue 2 years ago • 2 comments

What changes were proposed in this pull request?

This pr is aimed to refactor the support of selected vector.

Why are the changes needed?

reduce code duplication

How was this patch tested?

UT(TestSelectedVector)

deshanxiao avatar Oct 08 '22 10:10 deshanxiao

Also CC @dongjoon-hyun @guiyanakuang Thanks~

deshanxiao avatar Oct 09 '22 03:10 deshanxiao

cc @pavibhai too

dongjoon-hyun avatar Oct 09 '22 19:10 dongjoon-hyun

I have added a IllegalArgumentException when someone else passed wrong maxSize. Thank you @wgtmac

deshanxiao avatar Oct 20 '22 07:10 deshanxiao

Hi @pavibhai Could you please help me review this PR?

deshanxiao avatar Dec 06 '22 07:12 deshanxiao