openwhisk-deploy-kube icon indicating copy to clipboard operation
openwhisk-deploy-kube copied to clipboard

values not being respect in values.yaml file

Open zyue110026 opened this issue 1 year ago • 0 comments

We have noticed five instances of incorrect helming in your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

grafana.imagePullPolicy, elasticsearch.service.type, elasticsearch.service.nodePort, elasticsearch.service.loadBalancerIP, and elasticsearch.service.loadBalancerSourceRanges are not take affect when change their values to others. This is due to missing implementation for this value in grafana-pod.yaml file:

https://github.com/apache/openwhisk-deploy-kube/blob/5a5a2168c9c0342c026ca137f96fa9d2c8ae2748/helm/openwhisk/templates/grafana-pod.yaml#L65

and elasticsearch-svc.yaml:

https://github.com/apache/openwhisk-deploy-kube/blob/5a5a2168c9c0342c026ca137f96fa9d2c8ae2748/helm/openwhisk/templates/elasticsearch-svc.yaml#L32-L37

Expected Behavior

These values should take affect when changing them or delete them from values.yaml file

Actual Behavior

All values mentioned in this issue are not being respect.

zyue110026 avatar Aug 08 '24 15:08 zyue110026