openoffice icon indicating copy to clipboard operation
openoffice copied to clipboard

Stax removal from source tree

Open leginee opened this issue 4 years ago • 2 comments

As suggested in the Discussion on dev, I have created a patch that removes Stax.

also see Bug 128383

My testing has been so for:

  • a successfull build on Linux
  • executed a function in OpenOffice that is affected (see bug comment 3)

leginee avatar Jun 07 '20 07:06 leginee

There's a dependency from filter -> saxon -> stax

$ grep SAXON filter -R
filter/prj/build.lst:fl      filter  :    L10N:l10n svtools unotools xmloff cppu tools cppuhelper sal svx javaunohelper jvmaccess canvas SAXON:saxon LIBXSLT:libxslt basegfx NULL
filter/source/xsltfilter/makefile.mk:.IF "$(DISABLE_SAXON)" == ""
filter/source/xsltfilter/makefile.mk:.IF "$(SYSTEM_SAXON)" == "YES"
filter/source/xsltfilter/makefile.mk:XCLASSPATH:=$(XCLASSPATH)$(PATH_SEPERATOR)$(SAXON_JAR)

Apparently the xsltfilter uses it. Not sure where xsltfilter is used but maybe this helps: https://wiki.openoffice.org/wiki/Documentation/DevGuide/OfficeDev/Integrating_Import_and_Export_Filters

DamjanJovanovic avatar Jun 07 '20 08:06 DamjanJovanovic

Yes that is correct. Let me Quote Pedro Giffuni from the discussion:

While looking for candidates to remove stuff, consider stax. It is
included in Java since JDK5.

So I tried if something breaks. XSLTFILTER is used only in the MS Docuxment import I think, so I loaded a document with my testbuild of AOO and did so far not find any issues.

leginee avatar Jun 07 '20 08:06 leginee