openoffice
openoffice copied to clipboard
apache
Possible fix for issue 60859
If 1st slide is hidden and selected, show presentation does start after this.
Thanks to iammisc for this patch https://bz.apache.org/ooo/show_bug.cgi?id=60859
Please find a Windows build here: https://www.dropbox.com/scl/fi/ph0fogxba7wkbvxlfsr96/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_Slide.exe?rlkey=vaxkxtaq9ix6vqms9q5d1uf15&dl=0
I cannot comment on the code itself but it does seem to fix the issue. If first slide is hidden, presentation now starts with the second slide.
After some testing I have found a problem: I get a crash when I hide the last slide, select it and start a presentation (by pressing F5). This does not happen when there is only one slide.
After some testing I have found a problem: I get a crash when I hide the last slide, select it and start a presentation (by pressing F5). This does not happen when there is only one slide.
It may crash due to those >. @Pilot-Pirx if you can:
- reproduce the problem on your build,
- change
>into>=and rebuild, - demonstrate on your own computer that it does not crash any more,
then you are good to merge with the above edit.
I updated my build now with the above changes, but unfortunately it still crashes...
The logic had to be a little more complex than that. If there is a visible slide after the selection, then it has to be selected. Otherwise, we have to search for a visible slide backward.
It did build fine and I have no crashes anymore. The behavior now is logical for me. Maybe this is something we would want to backport to AOO41X?
Please find a build for Windows here: https://www.dropbox.com/scl/fi/ph0fogxba7wkbvxlfsr96/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_slide.exe?rlkey=vaxkxtaq9ix6vqms9q5d1uf15&dl=0
