feat(core): implement delete with recursive

Open meteorgan opened this issue 9 months ago • 5 comments

Which issue does this PR close?

Part of #3922.

Rationale for this change

implement recursive deletion

What changes are included in this PR?

Are there any user-facing changes?

Mar 13 '25 15:03 meteorgan

I'm considering another approach. Why don't we implement this functionality in Deleter ? It would make it more explicit. what do you think ? @Xuanwo

Mar 19 '25 13:03 meteorgan

I'm considering another approach. Why don't we implement this functionality in Deleter ? It would make it more explicit. what do you think ? @Xuanwo

Would you like to make it more explicit? What's your current plan?

Mar 19 '25 15:03 Xuanwo

Would you like to make it more explicit? What's your current plan?

I've basically implemented recursive deletion in CompleteLayer, but the code looks somewhat similar to Deleter and BatchDeleter, you can take a look. I'm considering whether implementing this logic in Deleter would be a better choice.

Mar 19 '25 15:03 meteorgan

Besides, The logic in CompleteLayer is pretty hidden, Moving it to Deleter would make it more obvious and straightforward.

Mar 19 '25 15:03 meteorgan

Or, we could implement RecursiveDeleter based on Deleter

Mar 21 '25 11:03 meteorgan