opendal icon indicating copy to clipboard operation
opendal copied to clipboard

feat(services/gdrive): List shows modified timestamp gdrive

Open erickguan opened this issue 1 year ago • 1 comments

Which issue does this PR close?

Part of #4746.

Are there any user-facing changes?

None.

erickguan avatar Oct 22 '24 11:10 erickguan

I did some experimentation (patch) with async support for listing operations, which helps reduce runtime as expected. However, extending OpList introduces a "breaking" change. Since OpenDAL has a compatibility package, I’m happy to coordinate with you when you're preparing for a breaking release, to minimize the amount of work on both sides. There's no urgency regarding async support, though.

A few other observations from running the behavior tests (not related to the PR):

  1. The behavior test fails on my local machine but passes in CI. I’m investigating the cause casually.
  2. The UUID random generation in behavior tests creates multiple levels of UUIDs. While this results in an extremely low chance of collision in the CI for OpenDAL's test accounts, I’d like to reduce the number of levels when running against my environment too.

erickguan avatar Oct 22 '24 19:10 erickguan

@Xuanwo Thanks for the pointer. I've figured out how the PageList and Google Drive backend work together, but I’m currently stuck on a failing test with MinIO in the complete layer. Am I on the right track in continuing this PR?

From what I understand, the `CompleteLayer`` depends on the behavior of different services. Since you mentioned that work on metakey is underway, I’m trying not to alter OpenDAL’s behavior. Unfortunately, adding the new stat behavior in this layer breaks the MinIO service.

erickguan avatar Oct 27 '24 19:10 erickguan

Also related to https://github.com/apache/opendal/discussions/5287

Xuanwo avatar Nov 06 '24 03:11 Xuanwo

Thanks for tentative checking in with metakey!

erickguan avatar Nov 06 '24 11:11 erickguan

After a closer look, can I pause this PR until your metakey work?

erickguan avatar Nov 06 '24 18:11 erickguan

After a closer look, can I pause this PR until your metakey work?

Yes, after the metakey is refactored, our work here will be much cleaner.

Xuanwo avatar Nov 07 '24 03:11 Xuanwo

Yes, after the metakey is refactored, our work here will be much cleaner.

Hi, you can continue your work now.

Xuanwo avatar Nov 14 '24 16:11 Xuanwo

Thanks for the ping! I'll pick it up and ping you when it's ready.

erickguan avatar Nov 14 '24 16:11 erickguan

Thanks for the ping! I'll pick it up and ping you when it's ready.

Thank you for your patience. Looking forward to your PR.

Xuanwo avatar Nov 14 '24 16:11 Xuanwo