opendal icon indicating copy to clipboard operation
opendal copied to clipboard

Tracking Issues with Conditional Requests

Open Xuanwo opened this issue 1 year ago • 5 comments

OpenDAL supports conditional requests at the API level, although not all supported services have implemented them. This issue is used to track their implementation.

Steps

Implement if_none_match for write like this https://github.com/apache/opendal/pull/5129

https://github.com/apache/opendal/blob/b92cfc41ba0a93acc5ff519b48af262bd91585d9/core/src/services/s3/core.rs#L335-L337

Services

  • [ ] s3 (If-None-Match in multipart upload)
  • [ ] azblob
  • [ ] azdls
  • [ ] cos (seems not supported, we need to check and try)
  • [ ] gcs
  • [ ] obs (seems not supported, we need to check and try)
  • [ ] oss (seems not supported, we need to check and try)

Xuanwo avatar Oct 21 '24 06:10 Xuanwo

Hello @ForestLH, thank you for adding support for S3's conditional write. However, the previous PR only covered simple writes. Would you be interested in extending this to multipart uploads as well?

Xuanwo avatar Oct 21 '24 08:10 Xuanwo

Hello @ForestLH, thank you for adding support for S3's conditional write. However, the previous PR only covered simple writes. Would you be interested in extending this to multipart uploads as well?

Sure, my pleasure. But I don't have an account for one of these cloud services(like cos, azblob, azdls...), and I want to know some easier methods than sign up for them to test my code. Thanks.

ForestLH avatar Oct 21 '24 08:10 ForestLH

For Azblob, you can use https://github.com/Azure/Azurite. We have a fixture available at: https://github.com/apache/opendal/blob/main/fixtures/azblob/docker-compose-azurite.yml.

For other services, we have only configured continuous integration so far. You can submit PR and I can help trigger the CI for you.

Xuanwo avatar Oct 21 '24 08:10 Xuanwo

For Azblob, you can use https://github.com/Azure/Azurite. We have a fixture available at: https://github.com/apache/opendal/blob/main/fixtures/azblob/docker-compose-azurite.yml.

For other services, we have only configured continuous integration so far. You can submit PR and I can help trigger the CI for you.

Thanks for your help. plz assign me, I will try it.

ForestLH avatar Oct 21 '24 08:10 ForestLH

Thank you @ForestLH!

Xuanwo avatar Oct 21 '24 08:10 Xuanwo

I'm sorry for not reporting the progress for so long, because I have a lot of things to do recently. I'm so sorry to tell you that I may not have time to do this issue lately, but I found out that @kemingy is doing this.

@Xuanwo

ForestLH avatar Nov 13 '24 09:11 ForestLH

I'm sorry for not reporting the progress for so long, because I have a lot of things to do recently.

Thank you for watching this. I look forward to working with you in the future.

Xuanwo avatar Nov 13 '24 10:11 Xuanwo