opendal icon indicating copy to clipboard operation
opendal copied to clipboard

chore!: fix typo customed should be customized

Open tisonkun opened this issue 1 year ago • 5 comments

@Xuanwo There is a similar typo in reqsign also. Please think of if we'd introduce a breaking change to fix it.

tisonkun avatar Jul 02 '24 23:07 tisonkun

Thank you for this PR. I will delay merging it for now since it introduces breaking changes. Perhaps we can also update the reqsign version at the same time.

Xuanwo avatar Jul 03 '24 01:07 Xuanwo

@Xuanwo would you work on a reqsign fix? Or I may handle it.

tisonkun avatar Jul 03 '24 02:07 tisonkun

@Xuanwo would you work on a reqsign fix? Or I may handle it.

I would appreciate it if you could submit a PR to reqsign.

Xuanwo avatar Jul 03 '24 02:07 Xuanwo

Here it is - https://github.com/Xuanwo/reqsign/pull/452

tisonkun avatar Jul 03 '24 02:07 tisonkun

Hi, I want to address https://github.com/apache/opendal/issues/4850 first before start developing of 0.48. So this PR will be hold until then.

Xuanwo avatar Jul 03 '24 05:07 Xuanwo