opendal icon indicating copy to clipboard operation
opendal copied to clipboard

Published 20 hours ago • verified publisher icon apache

feat: Add IPFS backend

Open xprazak2 opened this issue 1 year ago • 2 comments

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Adds a new backend service provider - IPFS

xprazak2 avatar Jul 30 '22 12:07 xprazak2

@xprazak2 Hi, are you still working on this PR?

Xuanwo avatar Aug 11 '22 04:08 Xuanwo

I am still working on it, apologies it is taking me so long. I think I have addressed all the comments except for using new_http_channel, I might need a bit more guidance on it. I was looking at it previously, but I am not sure how to plug it in. I can use Box::pin to pass fut into RequestWriter and skip IpfsWriterFuture but then I get lifetime error: io-channel

xprazak2 avatar Aug 14 '22 09:08 xprazak2

We have a refactor in https://github.com/datafuselabs/opendal/pull/556 to make it easier to implement IPFS backend, PTAL.

Xuanwo avatar Aug 23 '22 05:08 Xuanwo

Having access to the reader made it much easier to implement write. I rebased and removed IPFS SDK.

xprazak2 avatar Aug 27 '22 14:08 xprazak2

Having access to the reader made it much easier to implement write. I rebased and removed IPFS SDK.

Please ping me back when you are ready. And leaving comments for any ideas. I'm willing to help.

Xuanwo avatar Aug 27 '22 14:08 Xuanwo

@Xuanwo, all green now.

xprazak2 avatar Aug 27 '22 19:08 xprazak2

Great, thanks for your PR!

Xuanwo avatar Aug 29 '22 03:08 Xuanwo