opendal icon indicating copy to clipboard operation
opendal copied to clipboard

Tracking issues of integration `unftp-sbe`

Open Xuanwo opened this issue 1 year ago • 9 comments

https://github.com/apache/opendal/pull/4765 has added most features around unftp-sbe, this issue is used to track the remaining issues.

Tasks

  • [ ] Add README for this project
  • [ ] Add basic example for this project
  • [ ] Setup CI for unftp-sbe
  • [ ] Remove Cargo.lock file

Xuanwo avatar Jun 19 '24 04:06 Xuanwo

cc @George-Miao, would you like to take a look?

Xuanwo avatar Jun 19 '24 15:06 Xuanwo

Sure. I'll add the README and examples.

George-Miao avatar Jun 19 '24 15:06 George-Miao

Sure. I'll add the README and examples.

Thanks a lot!

Xuanwo avatar Jun 19 '24 15:06 Xuanwo

How should the CI part be done? @Xuanwo

George-Miao avatar Jun 25 '24 12:06 George-Miao

How should the CI part be done? @Xuanwo

We can setup some basic CI first like clippy and tests

Xuanwo avatar Jun 25 '24 14:06 Xuanwo

All tasks have been done. Should we close the issue?

George-Miao avatar Jun 26 '24 02:06 George-Miao

Hi, do you think it's a good idea to add some tests for ubftp-sbe integration like https://github.com/bolcom/libunftp/tree/master/crates/unftp-sbe-gcs/tests? I feel like we can at least test it with fs, s3, gcs and azblob.

You can finish the tests part and I'm willing to get it ready in our workflow.

Xuanwo avatar Jun 26 '24 02:06 Xuanwo

I'm happy that unftp upstream is gooding to use this integration directly: https://github.com/bolcom/unFTP/issues/183

Before we start the work at upstream side, how about finishing the test work first? I want to avoid the unexpected issues at upstream.

Xuanwo avatar Jun 27 '24 04:06 Xuanwo

Current docs for unftp-sbe-opendal doesn't look good

image

Would you like to track it in a new issue or in this tracking issue?

Xuanwo avatar Jul 01 '24 06:07 Xuanwo