opendal icon indicating copy to clipboard operation
opendal copied to clipboard

fix(services/fs,hdfs): fix poll_close when retry

Open hoslo opened this issue 1 year ago • 6 comments

fixes #4058

hoslo avatar Feb 04 '24 03:02 hoslo

Hi, @hoslo, it's best to avoid force-pushing so we can track the changes made since the last commit. We will squash all the commits while merging.

Xuanwo avatar Feb 04 '24 04:02 Xuanwo

Hi, @hoslo, it's best to avoid force-pushing so we can track the changes made since the last commit. We will squash all the commits while merging.

I understand, is there anything wrong with the test I added? Never written this before.

hoslo avatar Feb 04 '24 04:02 hoslo

I understand, is there anything wrong with the test I added? Never written this before.

We can add

env:
  RUST_BACKTRACE: 1

before jobs so we can have backtrace while error triggered.

And our tests failed for close succeed without error which is not expected.

Xuanwo avatar Feb 04 '24 04:02 Xuanwo

Hi, @hoslo, I reported the issue to tokio instead: https://github.com/tokio-rs/tokio/issues/6325

Xuanwo avatar Feb 04 '24 10:02 Xuanwo

Hi, @hoslo, could you fixing the HDFS issue first? We have a user facing the exact same problem.

We can fix the fs part later.

Xuanwo avatar Mar 01 '24 07:03 Xuanwo

Hi, @hoslo, could you fixing the HDFS issue first? We have a user facing the exact same problem.

We can fix the fs part later.

I created a new PR for hdfs close, plz check it.

hoslo avatar Mar 04 '24 06:03 hoslo

Closed as stale, conflict and superseded.

If the fs case is yet to be resolved, we should open a new PR instead.

tisonkun avatar Apr 01 '24 06:04 tisonkun