`fs::Writer::poll_close` can't be retried multiple times when error occurs

[sundy-li]

https://github.com/apache/opendal/blob/3c4e2f1c42b88323ed13c4eb56b95e75b98b75a9/core/src/services/fs/writer.rs#L67C8-L91

    fn poll_close(&mut self, cx: &mut Context<'_>) -> Poll<Result<()>> {
        loop {
            if let Some(fut) = self.fut.as_mut() {
                let res = ready!(fut.poll_unpin(cx));
                self.fut = None;
                return Poll::Ready(res);
            }


            let mut f = self.f.take().expect("FsWriter must be initialized");
            ...
    }

If any error happens(eg: disk full), retry layer will retry to call poll_close function, but the self.f is taken, so panic happens.

[Xuanwo]

Also affects hdfs

[hoslo]

@Xuanwo It seems to be running fine during the retry. Do you see any issues with this? https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=b7bb0b4ad4ddc48cc08566694b41adb8

[Xuanwo]

@Xuanwo It seems to be running fine during the retry. Do you see any issues with this? https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=b7bb0b4ad4ddc48cc08566694b41adb8

Apologies for not updating you on the progress. The main issue is that poll_close takes F and doesn't return it when an error occurs. We could adjust the future to instead return a (F, Result<()>).

[hoslo]

@Xuanwo重试期间似乎运行良好。您认为这有什么问题吗？https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=b7bb0b4ad4ddc48cc08566694b41adb8

很抱歉没有向您通报进展情况。主要问题是发生错误时poll_close接受F但不返回它。我们可以调整 future 以返回(F, Result<()>).

My link above does this, can I create a new PR for this?

[Xuanwo]

My link above does this, can I create a new PR for this?

Welcome! Thanks in advance.

[tisonkun]

@Xuanwo what is the progress of this issue?

I saw #4141 has been superseded by #4309, but perhaps the original issue is yet to resolved?

[Xuanwo]

I saw #4141 has been superseded by #4309, but perhaps the original issue is yet to resolved?

Yes, I'm working with the tokio team on this https://github.com/tokio-rs/tokio/pull/6330