apache
feat(services/s3): Add object versioning support
The code is OK.
But as what @Xuanwo said, we don't need to support multiple versions for now.
If we want to support multiple version for S3 service, I think we need support list/(get the object by version) at the same time. Otherwise the API would be not symmetry if we just add it for delete api
But as what @Xuanwo said, we don't need to support multiple versions for now.
This is incorrect.
I'm not saying we don't need to support multiple versions for now. What I meant is that we should consider version as part of our public API and test it within the same behavioral test suites.
If we want to support multiple version for S3 service, I think we need support list/(get the object by version) at the same time. Otherwise the API would be not symmetry if we just add it for delete api
Thay are already added in our Object Version RFC.
Is this PR still under development? We are very interested in using OpenDAL for reading and writing versioned files on S3 buckets, and it looks like we can't do that until this PR is merged.
We would be delighted to help you with testing!
Is this PR still under development? We are very interested in using OpenDAL for reading and writing versioned files on S3 buckets, and it looks like we can't do that until this PR is merged.
We would be delighted to help you with testing!
Thank you for your attention! I'm still working on the development. I will finish it as soon as possible.
Thanks. Any update?
On Mar 13, 2024, at 20:55, Suyan @.***> wrote:
Is this PR still under development? We are very interested in using OpenDAL for reading and writing versioned files on S3 buckets, and it looks like we can't do that until this PR is merged.
We would be delighted to help you with testing!
Thank you for your attention! I'm still working on the development. I will finish it as soon as possible.
— Reply to this email directly, view it on GitHub https://github.com/apache/opendal/pull/3943#issuecomment-1996350596, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAE2T6DX7E23RS6OP4SIKDYYENT3AVCNFSM6AAAAABBRUC7YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJWGM2TANJZGY. You are receiving this because you commented.
Thanks. Any update?
Thanks for the inquery. I will working on this after 0.47 released (about this week).
No pressure, but very curious if there is any progress...
Hello, apologies for not keeping you updated promptly. I'm currently working on designing the object version as well as addressing other feature requests such as https://github.com/apache/opendal/issues/4321. I plan to initiate a PR before next week once the design is finalized.
Has been implemented by https://github.com/apache/opendal/pull/4873. Thanks @suyanhanx's effort.