opendal icon indicating copy to clipboard operation
opendal copied to clipboard

Is it possible to make sftp available on windows?

Open Xuanwo opened this issue 2 years ago • 14 comments

Hi, sftp is marked as unix only. But windows seems have sftp support too. I want to know is it possible to make sftp available on windows and macos?

Xuanwo avatar Aug 29 '23 05:08 Xuanwo

cc @silver-ymz and @NobodyXu for comments.

Xuanwo avatar Aug 29 '23 05:08 Xuanwo

It seems be blocked by https://github.com/openssh-rust/openssh-mux-client/issues/6

And openssh-rust windows support has been tracked in https://github.com/openssh-rust/openssh/milestone/2

silver-ymz avatar Aug 29 '23 05:08 silver-ymz

Thanks a lot for the information!

Xuanwo avatar Aug 29 '23 05:08 Xuanwo

@silver-ymz is right, it's blocked on that issue and I don't have much time to work on it recently.

Would probably have to re-consider how to implement it, probably reducing scope and simplify the impl (I added a bunch custom sync primitives that are more performant but just wasting effort) and start implementing it.

NobodyXu avatar Aug 29 '23 05:08 NobodyXu

I would welcome any PR on that and willing to spend my time reviewing them quickly after PR opens/updates and answering questions for as long as it takes

I'm currently busy with my $DAYJOB and other open source projects, so it would take a long time until I get to do it myself.

NobodyXu avatar Aug 29 '23 05:08 NobodyXu

I'm currently busy with my $DAYJOB and other open source projects, so it would take a long time until I get to do it myself.

Thanks a lot for your contribution!

I initiated this inquiry to gather information about the context, and now that I am aware of its feasibility, it has unfortunately been blocked. We will proceed with this task once we receive sufficient user requests for this feature. Therefore, there is no need to rush.

Xuanwo avatar Aug 29 '23 05:08 Xuanwo

cc @silver-ymz, would you like to start a PR to update the comments about sftp services that unix only? This will allow users who are interested in this feature to leave their comments here and contribute to its development. I think we can link to this issue directly.

Xuanwo avatar Aug 29 '23 05:08 Xuanwo

I'd like to do it. And we can also update the comments about password login support. We can link it to https://github.com/openssh-rust/openssh/issues/119. I think this is also a feature that users expect.

silver-ymz avatar Aug 29 '23 05:08 silver-ymz

We can link it to openssh-rust/openssh#119. I think this is also a feature that users expect.

I prefer to start an issue at OpenDAL, link to openssh-rust in the issue. And our docs should only link to OpenDAL's issue.

Xuanwo avatar Aug 29 '23 06:08 Xuanwo

I have opened an issue #2966 to track password login support.

silver-ymz avatar Aug 29 '23 06:08 silver-ymz

Hi, I would like to suggest removing the blocked by upstream label. It seems more like pressure on the upstream instead of being helpful.

Let me clarify the following points:

  • No users have requested this feature.
  • The upstream is willing to accept this contribution but it has been postponed due to lack of time.
  • We proposed the feature request ourselves and it should not burden the upstream.
  • We are not blocked and there is no need for us to add this label.

Xuanwo avatar Aug 29 '23 07:08 Xuanwo

As we use opendal in rustic (thank you very much for your great project!!), I wanted to mention that we would like to request this feature.

aawsome avatar Jan 18 '24 08:01 aawsome

Opened openssh-rust/openssh#152 to use russh in openssh.

I will have to find some free time to work on it though

NobodyXu avatar Aug 23 '24 10:08 NobodyXu

I will have to find some free time to work on it though

Thank you!

Xuanwo avatar Aug 23 '24 10:08 Xuanwo