opendal icon indicating copy to clipboard operation
opendal copied to clipboard

servcices/vercel_artifacts: Tracking issues of not passed test cases

Open Xuanwo opened this issue 2 years ago • 9 comments

There are following tests still failed:

failures:
    services_vercelartifacts::write_test_create_dir
    services_vercelartifacts::write_test_create_dir_existing
    services_vercelartifacts::write_test_delete
    services_vercelartifacts::write_test_delete_empty_dir
    services_vercelartifacts::write_test_delete_not_existing
    services_vercelartifacts::write_test_delete_stream
    services_vercelartifacts::write_test_delete_with_special_chars
    services_vercelartifacts::write_test_fuzz_offset_reader
    services_vercelartifacts::write_test_fuzz_part_reader
    services_vercelartifacts::write_test_fuzz_range_reader
    services_vercelartifacts::write_test_read_full
    services_vercelartifacts::write_test_read_large_range
    services_vercelartifacts::write_test_read_range
    services_vercelartifacts::write_test_read_with_dir_path
    services_vercelartifacts::write_test_read_with_special_chars
    services_vercelartifacts::write_test_reader_from
    services_vercelartifacts::write_test_reader_range
    services_vercelartifacts::write_test_stat
    services_vercelartifacts::write_test_stat_dir
    services_vercelartifacts::write_test_stat_not_cleaned_path
    services_vercelartifacts::write_test_stat_not_exist
    services_vercelartifacts::write_test_stat_root
    services_vercelartifacts::write_test_stat_with_special_chars
    services_vercelartifacts::write_test_write
    services_vercelartifacts::write_test_write_with_special_chars

To address them, we should:

  • Implement stat/delete/create_dir
    • [x] Implement stat support for vercel artifacts #2649
    • [ ] Implement delete support for vercel artifacts
    • [ ] Implement create_dir support for vercel artifacts
  • Some cases seems related to vercel's range support, we need more research:
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Read(39693)
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Seek(End(-641647))
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Seek(Start(1002031))
[2023-05-02T17:42:43Z DEBUG behavior::utils] 299f30d9-f809-4a37-8f92-42e2193d09e7 perform fuzz action: Next
[2023-05-02T17:42:43Z DEBUG rustls::conn] Sending warning alert CloseNotify
thread 'services_vercelartifacts::write_test_fuzz_offset_reader' panicked at 'assertion failed: `(left == right)`
  left: `"2010485b33902bd343ad7402b91a8c74ce384df587a71682745f4239e0398893"`,
 right: `"0b1819ed21e022a6657c5dc7edea166b50d0d13f31291c62dde9def6c4a1a6f1"`: check next failed: output bs is different with expected bs, actions: [Read(377685), Next, Seek(End(-3143164)), Next, Seek(End(-2273789)), Next, Read(39693), Next, Next, Seek(End(-641647)), Seek(Start(1002031)), Next]', core/tests/behavior/utils.rs:267:13
[2023-05-02T17:42:43Z DEBUG opendal::services] service=vercel_artifacts operation=read path=299f30d9-f809-4a37-8f92-42e2193d09e7 read=55148 -> data read finished
[2023-05-02T17:42:43Z DEBUG rustls::conn] Sending warning alert CloseNotify
test services_vercelartifacts::write_test_fuzz_offset_reader ... FAILED

Xuanwo avatar May 02 '23 17:05 Xuanwo

Hi @Retrospection, are you interested?

Xuanwo avatar May 02 '23 17:05 Xuanwo

Hi @Retrospection, are you interested?

yep,I'd like to take this~

Retrospection avatar May 02 '23 17:05 Retrospection

@Xuanwo I may be too busy in work to finish this issue, so badly sorry for giving up.

Retrospection avatar Jul 13 '23 13:07 Retrospection

@Xuanwo I may be too busy in work to finish this issue, so badly sorry for giving up.

There's no need to apologize. Take your time and enjoy yourself!

Xuanwo avatar Jul 13 '23 14:07 Xuanwo

Are we still working on this? If yes, I would like try to solve the left problems.

dqhl76 avatar Sep 12 '23 12:09 dqhl76

If yes, I would like try to solve the left problems.

Most issues are related to Vercel artifacts and their own support. I'm not sure if we can resolve them. Would you like to check the docs first?

Xuanwo avatar Sep 12 '23 12:09 Xuanwo

If yes, I would like try to solve the left problems.

Most issues are related to Vercel artifacts and their own support. I'm not sure if we can resolve them. Would you like to check the docs first?

Thanks for the kind reminding

dqhl76 avatar Sep 12 '23 12:09 dqhl76

https://vercel.com/docs/rest-api/endpoints#artifacts After looking at the document, it seems that there is no deletion operation and directory structure.

Borber avatar Jan 10 '24 00:01 Borber

I tend to remove this service now, as there are no users and no one interested in maintaining it.

Xuanwo avatar Sep 15 '25 17:09 Xuanwo