opendal icon indicating copy to clipboard operation
opendal copied to clipboard

idea: Enable oss-fuzz support for ObjectReader

Open Xuanwo opened this issue 2 years ago • 1 comments

It's worth running fuzz tests upon oss-fuzz

Xuanwo avatar Jan 28 '23 16:01 Xuanwo

Let me take a look

ClSlaid avatar Mar 20 '23 03:03 ClSlaid

Hello, are there any updates on this issue?

Xuanwo avatar Apr 08 '23 05:04 Xuanwo

Hello, @ClSlaid. I have removed the assignment of this issue from you so that others can also participate. Thank you for your interest!

Xuanwo avatar Apr 12 '23 04:04 Xuanwo

Hi, team, Can I have one try on this? it looks so interesting. But I dont have so much time in the day but night... so I may need more time on that.

So May I? Please feel free to let me know any concerns from you, thx!

Gnosnay avatar Apr 27 '23 15:04 Gnosnay

Hello, @Yansongsongsong. Thank you for your interest! However, we have already submitted this issue as an OSPP project. Would you be interested in taking on this project as a student?

More details could be found at https://summer-ospp.ac.cn/org/orgdetail/111e2fe9-025b-46da-a6c5-1b0de297abdd?lang=en

Xuanwo avatar Apr 28 '23 03:04 Xuanwo

Hello, @Yansongsongsong. Thank you for your interest! However, we have already submitted this issue as an OSPP project. Would you be interested in taking on this project as a student?

More details could be found at https://summer-ospp.ac.cn/org/orgdetail/111e2fe9-025b-46da-a6c5-1b0de297abdd?lang=en

i dont really care about which role i am to make a contribution. but i am not a student any more. if it is acceptable. i am okay actually.

BTW the link you give here is not open for application.

Here is my plan for this issue:

  1. make one pull request for oss-fuzz
  2. cuz the previous title is ObjectReader, i read a bit about behavior testing in tests folder. I plan to give some documentation for this part.
  3. Then fuzz target related. There are two ways:
    • maintain the fuzz target on oss-fuzz side. just like redis-rs .
      • pros & cons: no need to pull the whole opendal. but the code is maintained seperatedly.
    • maintain the fuzz target in openadal project, just like flate2-rs.
      • pros & cons: easy to maintain it for us. but during the building, it may need to pull all opendal. some stroage and network cost happens here.
  4. Then make the whole workflow work. There are some problems for the whole workflow integration:
    • Contact for oss-fuzz org. AFAIK, oss-fuzz side needs one contact who is really charge of this project. I think it should be the problem for communication and collaboration. let us see how to resolve it.
    • issue tracking. As oss-fuzz said, finally they will create one issue like JIRA ticket staff for us to reminder that we need to fix related problem. We may need to design one proper workflow to track these issues.
    • issue fixing. Same to above, we may give one proper workflow to know the issue, fix the issue and remind oss-fuzz side we have finished issue.

i just review the process roughly, so the plan may not be correct. Feel free to correct me and let me know your concern if you have.

For me i am free to seek the another issue is suitable for me to work with if this issue has been assigned to someone from OSPP activity.

thank you again for your help.

Gnosnay avatar Apr 28 '23 03:04 Gnosnay

  • maintain the fuzz target in opendal project, just like flate2-rs.

We shold do this at our side.

For me i am free to seek the another issue is suitable for me to work with if this issue has been assigned to someone from OSPP activity.

I apologize for not updating the issue description earlier. Please feel free to take a look at other issues.

Xuanwo avatar Apr 28 '23 04:04 Xuanwo

  • maintain the fuzz target in opendal project, just like flate2-rs.

We shold do this at our side.

For me i am free to seek the another issue is suitable for me to work with if this issue has been assigned to someone from OSPP activity.

I apologize for not updating the issue description earlier. Please feel free to take a look at other issues.

no worries. take it easy.

Gnosnay avatar Apr 28 '23 14:04 Gnosnay

Thanks for @Yansongsongsong's plan and @Xuanwo's explanation. I create a issue #2551 to track the implementation process.

dqhl76 avatar Jun 27 '23 06:06 dqhl76

Tracked in https://github.com/apache/incubator-opendal/issues/2551

Xuanwo avatar Jul 25 '23 01:07 Xuanwo