ofbiz-plugins
ofbiz-plugins copied to clipboard
apache
Improved: Project - MainActionMenu (OFBIZ-12484)
Currently the create buttons for the main objects of the project mgt plugin are located within the find and other widgets/templates of those objects. In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.
modified: ProjectMenus.xml - added MainActionMenu for users with CREATE permission in the component CommonScreens.xml - added MainActionMenu as an 'include-menu' ref in various common decorator screens. additional cleaning.
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @PierreSmits ,
Why removing comments in projectmgr/widget/CommonScreens.xml ?
HI @JacquesLeRoux,
I guess you are referring to:
<!-- The two default (global) stylesheets are added to the list of stylesheets to the first and second position -->
and
<!-- layoutSettings.headerImageUrl can be used to specify an application specific logo; if not set, then the global layoutSettings.commonHeaderImageUrl (specified in GlobalDecorator) will be used. --> <!--<set field="layoutSettings.headerImageUrl" value="/images/ofbiz_logo.png" global="true"/>-->
in the main-decorator screen in CommonScreens.xml. The motivations to remove this are:
- it does not serve any purpose. If it were for educational purposes having it in 1 location (e.g. the example application) would suffice and in any other location it would be superfluous.
- it is not present in template for CommonScreens.xml to initiate a new plugin.
- it is not present in committed plugins like firstdatapaymentgateway, pricat, msggateway, webpos
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
See analysis details on SonarCloud
Pierre about:
in the main-decorator screen in CommonScreens.xml. The motivations to remove this are:
- it does not serve any purpose. If it were for educational purposes having it in 1 location (e.g. the example application) would suffice and in any other location it would be superfluous.
- it is not present in template for CommonScreens.xml to initiate a new plugin.
- it is not present in committed plugins like firstdatapaymentgateway, pricat, msggateway, webpos
- I disagree it's always good to have information in CommonScreens.xml. There is such information in example component. It's not enough.
- I have just added them
- Those are marginals application. You might want to add these comment there ;)
@JacquesLeRoux
It is a pity that you regard several plugins as marginal. Maybe you should have voted against having it in the codebase when the moments occurred. More diligence would have led to better code and usability (remember the IDEAL stuff?).