ofbiz-framework Improved: Marketing-Main page (OFBIZ-13054)

Currently the 'main' view-map points to a screen showing a label In order to improve the user experience the main request-map and view-map should show what is most pressing in marketing to address: active campaigns and contact list communication events.

added:

MarketingPortletData.xml, having record definitions for PortalPage, Portlet, etc

modified::

ofbiz-component.xml: added data loader for MarketingPortletData.xml
controller.xml: changed view-map 'main' to point to screen Main in CommonScreens.xml
CommonScreens.xml: screen Main displaying a PortalPage
MarketingCampaignScreens.xml: adding screen Campaigns for active campaigns
MarketingCampaignForms.xml: adding grid Campaigns to list active campaigns
ContactListScreens.xml: adding screen CommEvents for active communication events
ContactListForms.xml: adding grid Campaigns to list active communication events

Apr 25 '24 06:04 PierreSmits

Hi Pierre,

The patch does no apply in Elipse nor with git apply:

C:\projectsASF\Git\ofbiz-framework>git apply 785.patch 785.patch:70: trailing whitespace. <PortalPage portalPageId="marketing_MAIN" portalPageName="Marketing Main Page" 785.patch:71: trailing whitespace. description="The main portal page of the marketing application" error: applications/marketing/data/MarketingPortletData.xml: already exists in working directory

C:\projectsASF\Git\ofbiz-framework>git diff

C:\projectsASF\Git\ofbiz-framework>

May 09 '24 16:05 JacquesLeRoux

Now that is unfortunate. I will address this.

May 09 '24 18:05 PierreSmits

Hi @JacquesLeRoux ,

I have updated the pull request.

May 10 '24 06:05 PierreSmits

Hi,

About the error above where git diff did not give any information

error: applications/marketing/data/MarketingPortletData.xml: already exists in working directory
C:\projectsASF\Git\ofbiz-framework>git diff
C:\projectsASF\Git\ofbiz-framework>

I know now what happened. As I said

The patch does no apply in Elipse nor with git apply

I actually tried with Eclipse before and did not notice that MarketingPortletData.xml was already there but not added.

Now we have

C:\projectsASF\Git\ofbiz-framework>git apply 785.patch 785.patch:70: trailing whitespace. <PortalPage portalPageId="marketing_MAIN" portalPageName="Marketing Main Page" 785.patch:71: trailing whitespace. description="The main portal page of the marketing application" warning: 2 lines add whitespace errors.

You can neglect, it's OK (new lines, no trailing whitespaces)

About

-    <view-map name="main" type="screen" page="component://marketing/widget/CommonScreens.xml#main"/>
+    <view-map name="main" type="screen" page="component://marketing/widget/CommonScreens.xml#Main"/>
-    <screen name="main">
+    <screen name="Main">

Not needed. In current code 29 <screen name="main"> vs 7 <screen name="Main"> But maybe simple for you, not a pb finally.

More important is this Typo (N/M) <entity-resource type="data" reader-name="seed" loader="main" location="data/NarketingPortletData.xml"/> You see that's the brittle of portals. I also remember a space at head of a portal reference not bing easy to find.

Anyway tests are OK and I agree it's a good improvement. Though that could have been done with no new data in DB, isn't?

I'll fix the typo and push.

May 11 '24 07:05 JacquesLeRoux