ofbiz-framework icon indicating copy to clipboard operation
ofbiz-framework copied to clipboard

Improved: Use a version catalog

Open dtrunk90 opened this issue 1 year ago • 7 comments

Using a version catalog makes things easier:

  • You can update a single version for multiple artifacts (e.g. Tomcat)
  • You have all the artifacts and their versions at a single place separated from other stuff

See also https://docs.gradle.org/current/userguide/platforms.html

dtrunk90 avatar Jun 30 '23 16:06 dtrunk90

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 30 '23 23:06 sonarqubecloud[bot]

Hi @dtrunk90,

I remember having seen that before, but completly forgot about it. Could you please update the PR, or create anew. At 1st glance, the conflicts seem a bit hard to resolve

TIA

JacquesLeRoux avatar Feb 15 '24 13:02 JacquesLeRoux

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 05 '24 21:03 sonarqubecloud[bot]

Hi @JacquesLeRoux,

it took some hours but it's finally done.

dtrunk90 avatar Mar 05 '24 21:03 dtrunk90

@dtrunk90 Can you elaborate a bit more what advantages this approach brings? At first glance it seems to make things more complicate?

mbrohl avatar Mar 05 '24 22:03 mbrohl

Hi @dtrunk90, @mbrohl ,

I must say last time I just had a glance, notably on the Gradle Page. After reading a bit more there, with a glance as the resulting code here, I indeed wonder if we need that OOTB.

@dtrunk90, I suggest to start a thread in the dev ML ([email protected]). That's what we do when we hesitate and want to make a community decision. Just few explaining words should be enough.

JacquesLeRoux avatar Mar 06 '24 08:03 JacquesLeRoux

As a note, here is the Gradle page summary for the catalog feature:

In summary, using a catalog is always a good engineering practice as it centralizes common definitions, allows sharing of dependency versions or plugin versions, but it is an "implementation detail" of the build: it will not be visible to consumers and unused elements of a catalog are just ignored.

Again, not sure we need that, we need to deal with it in depth.

JacquesLeRoux avatar Mar 06 '24 08:03 JacquesLeRoux