Improved: Accounting Transactions - VIEW permissions (OFBIZ-12532)

[PierreSmits]

Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the accounting transactions screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions in unposted transactions.

To see/test with an unposed transaction: https://localhost:8443/accounting/control/EditAcctgTrans?organizationPartyId=Company&acctgTransId=10000

modified: GlScreens.xml

• restructured screen EditAcctgTrans to work with permissions
• additional cleanup and enhancements vis-a-vis consistency.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[mbrohl]

I think the removal of the blank lines between the elements makes the files less readable and maintanable. It would also be better to split between functional changes and code cleanup, would make it possible to only take the functional change and leave the (maybe unwanted) "cleanups".

[JacquesLeRoux]

Hi Michael,

I think the removal of the blank lines between the elements makes the files less readable and maintanable.

I initially had the same thought, because I think it's indeed less readable, add nothing and rather complicate reviews. But I know there are parts where it's done the way or the other. So I let it be. I'd not advice to set a rule for that, else, in the absolute, we would have to change everywhere it's already not conform to the new rule.

This said we can ask Pierre to remove these kind of changes and don't complete reviews if we see things diverging.

[mbrohl]

I did not intend to set a rule on this, I just gave my opinion as a reviewer. I would appreciate if those changes would be removed, though. There's always hope...

[JacquesLeRoux]

Hope is a fragile plant :smirk: