Improved: Party Rates - VIEW permissions (OFBIZ-12529)

[PierreSmits]

Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Party Rates screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions. To see:/test: for DemoEmployee (rates in demo data): https://localhost:8443/partymgr/control/EditPartyRates?partyId=DemoEmployee for DemoEmployee2 (after merge of PR74 in plugins): https://localhost:8443/partymgr/control/EditPartyRates?partyId=DemoEmployee2

Modified:

• PartyScreens.xml - restructured screen EditPartyRates to work with permissions
• PartyForms.xml - added grid PartyRates for users with VIEW permissions additional cleanup

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[mbrohl]

I think the removal of the blank lines between the elements makes the files less readable and maintanable. It would also be better to split between functional changes and code cleanup, would make it possible to only take the functional change and leave the (maybe unwanted) "cleanups".

[PierreSmits]

Thanks you for your opinion.

It would also be better to split between functional changes and code cleanup, would make it possible to only take the functional change and leave the (maybe unwanted) "cleanups". If you feel that strongly about it, go write a proposal and send that to the dev mailing list and start a discussion there.