ofbiz-framework icon indicating copy to clipboard operation
ofbiz-framework copied to clipboard

Published 20 hours ago • verified publisher icon apache

Improved: Cybersource - configuration (OFBIZ-12459)

Open PierreSmits opened this issue 3 years ago • 3 comments

Move 3rd party Fintech integration configuration for Cybersource from initialisation configuration to runtime configuration.

Modified:

  • payment.properties: removed Cybersource configuration aspects
  • AccountingSystemPropertiesData.xml: Cybersource configuration aspects
  • icsPaymentServices.java: switched from getPaymentGatewayConfigValue to EntityUtilProperties.getPropertyValue for Cybersource configuration aspects

PierreSmits avatar Dec 15 '21 11:12 PierreSmits

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 15 '21 11:12 sonarqubecloud[bot]

This also ignores the objection to focus on SystemProperty only. Removing the property file based configuration and replacing it with SystemProperty forces the user to use SystemProperty which is not reasonable. This should not go into the code base as-is.

mbrohl avatar Dec 15 '21 11:12 mbrohl

This should not go into the code base as is. Please leave the established mechanism/properties as is and only add SytemPropertyData as optional load data.

mbrohl avatar Jan 23 '22 11:01 mbrohl

We recently agreed about that. Anyway this branch has conflicts that I don't want to handle, closing

JacquesLeRoux avatar Sep 28 '22 05:09 JacquesLeRoux