ofbiz-framework icon indicating copy to clipboard operation
ofbiz-framework copied to clipboard

Improved: OFBiz audit/investigation (OFBIZ-12391)

Open PierreSmits opened this issue 3 years ago • 3 comments

modified: ModelEntity.java - adding fields for auditing/investigating record creation and modification by default to entities when OFBiz is initialised:

  • createdDate
  • createdByUserLogin
  • lastModifiedDate
  • lastModifiedByUserLogin

PierreSmits avatar Nov 19 '21 13:11 PierreSmits

AFAIK this can all be configured in the entity model as I mentioned in another PR some days ago. Why is this change necessary?

mbrohl avatar Nov 19 '21 13:11 mbrohl

Thank you for your feedback, Michael,

I am confident that you mentioned something somewhere about the aspect that something could be done somewhere else in OFBiz, but without actual reference to where this happened it hard to check whether it is pertaining to changes under this PR and/or related to the ticket associated. It could even be imaginary (not saying that it is).

So please provide the reference (preferably as a link), and if those comment there/then do not explicitly relate to the changes under this PR please also provide reasoning why it should.

It will surely help other contributors to form an opinion on whether having this in the code base, or not.

PierreSmits avatar Nov 19 '21 13:11 PierreSmits

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 20 '21 18:11 sonarqubecloud[bot]