nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

Published 20 hours ago • verified publisher icon apache

fs/mmap/msync: support msync and fix minor issue

Open Donny9 opened this issue 2 years ago • 1 comments

Summary

fs/mmap/msync: support msync and fix some minor issue

Follow: https://man7.org/linux/man-pages/man2/msync.2.html

Impact

Support msync

Testing

Ci

Donny9 avatar Apr 07 '22 02:04 Donny9

  • don't you need to distinguish MAP_SHARED/MAP_PRIVATE? copy-on-write mapping should not be written back to the file.
  • don't you need some reference counting on the file? i guess the file can be closed immediately after mmap.
  • i guess mmap should not modify file offset. (not specific to this PR)

yamt avatar Apr 07 '22 08:04 yamt

@Donny9 we can implement with the new mmap infrastructure which is simpler now: https://github.com/apache/nuttx/pull/8000 and https://github.com/apache/nuttx/pull/8026.

xiaoxiang781216 avatar Jan 10 '23 19:01 xiaoxiang781216