nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

mm: fix memory alignment

Open yamt opened this issue 3 years ago • 14 comments

Summary

Impact

Testing

tested with https://github.com/apache/incubator-nuttx-apps/pull/1125 also this fixed a crash seen with examples/sotest on sim/macOS

yamt avatar Apr 06 '22 09:04 yamt

i'm not sure why the ci is complaining on up_x11eventloop.c.

yamt avatar Apr 07 '22 06:04 yamt

i'm not sure why the ci is complaining on up_x11eventloop.c.

Try just to rebase the changes

pkarashchenko avatar Apr 07 '22 07:04 pkarashchenko

i'm not sure why the ci is complaining on up_x11eventloop.c.

Try just to rebase the changes

why? is it a known problem already fixed?

yamt avatar Apr 07 '22 07:04 yamt

i'm not sure why the ci is complaining on up_x11eventloop.c.

Try just to rebase the changes

why? is it a known problem already fixed?

https://github.com/apache/incubator-nuttx/pull/5988

pkarashchenko avatar Apr 07 '22 07:04 pkarashchenko

But mainline seems to be broken now: https://github.com/apache/incubator-nuttx/pull/5937#issuecomment-1091152830 So probably need to hold on

pkarashchenko avatar Apr 07 '22 07:04 pkarashchenko

i'm not sure why the ci is complaining on up_x11eventloop.c.

Try just to rebase the changes

why? is it a known problem already fixed?

#5988

thank you. i was expecting that the ci only runs nxstyle on files modified in a PR.

yamt avatar Apr 07 '22 07:04 yamt

i'm not sure why the ci is complaining on up_x11eventloop.c.

Try just to rebase the changes

why? is it a known problem already fixed?

#5988

thank you. i was expecting that the ci only runs nxstyle on files modified in a PR.

Yes. This should be true, but sometimes I see the issues like this. We can try just to restart the checks

pkarashchenko avatar Apr 07 '22 07:04 pkarashchenko

What is actually does is

6e0692c018 Merge fa714e92c5d53895f364fa920aaadb6028f0d659 into 53fef8d9c4457f3b4099997d4cbf894bbdb7146c
53fef8d9c4 arch/risc-v: Replace riscv_fault with riscv_exception
db012687f9 arch/sim: support simulator keyboard devices
b8a9d7da19 esp32: Add board support to TWAI/CANBus
[10](https://github.com/apache/incubator-nuttx/runs/5856746112?check_suite_focus=true#step:3:10)90e1a8ea xtensa/esp32: Add support to TWAI/CANBus controller
dfbf06e250 fix uinput rpmsg logic error
fa714e92c5 mm_initialize.c: Fix alignment
5d2c6b68[13](https://github.com/apache/incubator-nuttx/runs/5856746112?check_suite_focus=true#step:3:13) mm_malloc.c: Add assertions about alignment
ea1dc8595a mm_memalign.c: Add assertions about alignment
../nuttx/tools/checkpatch.sh -g ff0470d28a0875454f59fd6c87da0907d68ff6df..HEAD

pkarashchenko avatar Apr 07 '22 07:04 pkarashchenko

https://github.com/apache/incubator-nuttx/pull/6002 -- here is a change to restore a CI on mainline

pkarashchenko avatar Apr 07 '22 07:04 pkarashchenko

@yamt could you review #6011? "mm_initialize.c: Fix alignment" could be dropped from this PR.

xiaoxiang781216 avatar Apr 08 '22 10:04 xiaoxiang781216

i turned this a draft because i prefer https://github.com/apache/incubator-nuttx/pull/6011

yamt avatar Apr 11 '22 01:04 yamt

@yamt could you rebase this patch and fix the conflict?

xiaoxiang781216 avatar Apr 11 '22 05:04 xiaoxiang781216

@yamt this PR contain more ASSERT which is very useful. How about we merge it after the conflict get resolved?

xiaoxiang781216 avatar Apr 12 '22 07:04 xiaoxiang781216

@xiaoxiang781216 i will revisit later. not today.

yamt avatar Apr 12 '22 07:04 yamt

@yamt let finish the rest work in https://github.com/apache/incubator-nuttx/pull/7495

xiaoxiang781216 avatar Nov 01 '22 03:11 xiaoxiang781216