nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

arm: Fix "make export" for KERNEL build

Open yamt opened this issue 5 years ago • 10 comments

yamt avatar Feb 26 '20 06:02 yamt

Please merge when the conversation is resolved.

patacongo avatar Feb 26 '20 13:02 patacongo

@yamt could you review the new change?

xiaoxiang781216 avatar Mar 03 '20 03:03 xiaoxiang781216

@xiaoxiang781216 my understanding is that it isn't appropriate to add crt0.c to CMN_CSRCS as it's for kernel sources.

yamt avatar Mar 03 '20 04:03 yamt

@xiaoxiang781216 my understanding is that it isn't appropriate to add crt0.c to CMN_CSRCS as it's for kernel sources.

Good point, I will change to CMN_UCSRCS.

xiaoxiang781216 avatar Mar 03 '20 04:03 xiaoxiang781216

@xiaoxiang781216 what ensures UOBJS built before STARTUP_OBJS is being used?

yamt avatar Mar 03 '20 04:03 yamt

@xiaoxiang781216 what ensures UOBJS built before STARTUP_OBJS is being used?

export_startup depend on STARTUP_OBJS, so it isn't an issue, but UOBJS will be archived libuarch.a which mayn't what we want.

xiaoxiang781216 avatar Mar 03 '20 05:03 xiaoxiang781216

@yamt @xiaoxiang781216 Can we close this PR? it is almost four months old and there have been no updates or comments for almost three months now.

patacongo avatar May 28 '20 22:05 patacongo

@yamt please comment

jerpelea avatar Jun 02 '20 09:06 jerpelea

i guess the problem still exists. but i'm not looking at KERNEL build these days. it's great if someone more familiar with KERNEL build can take this over.

yamt avatar Jun 02 '20 10:06 yamt

@yamt could you fill the PR description. We can leave this open to indicate the solution needs testing.

protobits avatar Sep 13 '20 15:09 protobits