nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard

xtensa/esp32: Add option to disable raw esp-idf Wi-Fi log format

Open donghengqaz opened this issue 4 years ago • 2 comments

Summary

Add option to disable raw esp-idf Wi-Fi log format.

Impact

Try to fix log prefix being mixed from NuttX log device: https://github.com/apache/incubator-nuttx/issues/3157.

Testing

donghengqaz avatar Apr 01 '21 10:04 donghengqaz

I don't think this is the right way to fix the issue. You are conditioning the printing to a very specific case which is not really useful to have. The asprintf is also kind of a hack, involving an allocation/de-allocation every time. As you mentioned, this problem is on the caller side on ESP32 wifi drivers and must be fixed there.

protobits avatar Apr 01 '21 12:04 protobits

I don't think this is the right way to fix the issue. You are conditioning the printing to a very specific case which is not really useful to have. The asprintf is also kind of a hack, involving an allocation/de-allocation every time. As you mentioned, this problem is on the caller side on ESP32 wifi drivers and must be fixed there.

I agree with you, but our internal Wi-Fi team has a long plan, so I just can report this issue to them and when them select to do this is unknown, so I add this PR to hope this modification can do some help.

donghengqaz avatar Apr 02 '21 03:04 donghengqaz