nuttx icon indicating copy to clipboard operation
nuttx copied to clipboard
verified publisher icon apache

[BUG] NXStyle is not reporting up case hexadecimals

Open acassis opened this issue 8 months ago • 6 comments

Description / Steps to reproduce the issue

Image

On which OS does this issue occur?

[OS: Linux]

What is the version of your OS?

all

NuttX Version

mainline

Issue Architecture

[Arch: all]

Issue Area

[Area: Other]

Host information

nxstyle needs to detect hexadecimal with upper case and report a warning

Verification

  • [x] I have verified before submitting the report.

acassis avatar Apr 22 '25 16:04 acassis

What does a git bisect find?

TimJTi avatar Apr 22 '25 20:04 TimJTi

checkpatch.sh reports Upper case hex constant found still for me?

TimJTi avatar Apr 22 '25 20:04 TimJTi

@TimJTi strange, for some reason it didn't detect the issue in the CI.

@lupyuen do you know why CI's nxstyle didn't catch this issue?

acassis avatar Apr 23 '25 00:04 acassis

Sorry @simbit18 any idea why? Are we running a different nxstyle for CI? Thanks!

lupyuen avatar Apr 23 '25 00:04 lupyuen

Hi @lupyuen as far as I can see nxstyle is the same.

checkpatch.sh https://github.com/apache/nuttx/blob/216c4b00e2358fc0bb09db9c4eeb3cc0b240679a/tools/checkpatch.sh#L197

check.yml https://github.com/apache/nuttx/blob/216c4b00e2358fc0bb09db9c4eeb3cc0b240679a/.github/workflows/check.yml#L49

I did a test locally with nxstyle and it does not detect up case hexadecimals

simbit18 avatar Apr 23 '25 13:04 simbit18

Thanks for confirming @simbit18 !

acassis avatar Apr 23 '25 13:04 acassis