nuttx
nuttx copied to clipboard
apache
sim_uart: rm LF to CRLF convertion
LF to CRLF has been converted in syslog framework
Note: Please adhere to Contributing Guidelines.
Summary
rm LF to CRLF convertion
Impact
syslog
Testing
selftest
[Experimental Bot, please feedback here]
No, this PR does not meet the NuttX Requirements.
Missing Information:
- Summary:
- Why is the change necessary? What problem does it solve?
- What specific part of the syslog framework was changed?
- Impact:
- Is this a new feature, bug fix, or refactoring?
- How does this impact users of the syslog framework?
- Are there any compatibility concerns?
- Testing:
- Provide details about the build host and target used for testing.
- Include relevant testing logs from before and after the change to demonstrate the problem and the solution.
Recommendations:
- Expand the Summary: Explain the reasoning behind removing the LF to CRLF conversion. What issues did it cause?
- Clarify the Impact: Describe the specific changes to the syslog framework. Will users need to make any code adjustments?
- Provide Detailed Testing Information: List the operating systems, architectures, boards, and configurations used for testing. Share complete testing logs to validate the change's effectiveness.
Remember: A good PR clearly explains the problem, the solution, and how it was validated. Provide as much detail as possible to help reviewers understand and approve your changes.
let's ignore the ci break made by https://github.com/apache/nuttx/pull/14445.
